[PATCH] Fix initialization of runqueues

From: Samuel Thibault
Date: Wed Aug 02 2006 - 08:25:31 EST


Hi,

There's an odd thing about the nr_active field in arrays of runqueue_t:
it is actually never initialized to 0!... This doesn't yet trigger a
bug probably because the way runqueues are allocated make it so that
it is already initialized to 0, but that's not a safe way. Here is a
patch:

Initialize to zero the nr_active field of arrays of runqueues.
(fixes future potential dynamic allocation of runqueues).

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

--- linux-2.6.17-orig/kernel/sched.c 2006-06-18 19:22:40.000000000 +0200
+++ linux/kernel/sched.c 2006-08-02 14:23:02.000000000 +0200
@@ -6132,6 +6132,7 @@

for (j = 0; j < 2; j++) {
array = rq->arrays + j;
+ array->nr_active = 0;
for (k = 0; k < MAX_PRIO; k++) {
INIT_LIST_HEAD(array->queue + k);
__clear_bit(k, array->bitmap);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/