Re: [PATCH] Fix initialization of runqueues

From: Samuel Thibault
Date: Wed Aug 02 2006 - 12:55:28 EST


Ingo Molnar, le Wed 02 Aug 2006 17:24:19 +0200, a écrit :
>
> * Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> wrote:
>
> > Hi,
> >
> > There's an odd thing about the nr_active field in arrays of
> > runqueue_t: it is actually never initialized to 0!... This doesn't
> > yet trigger a bug probably because the way runqueues are allocated
> > make it so that it is already initialized to 0, but that's not a safe
> > way. Here is a patch:
>
> we do rely on zero initialization of bss (and percpu) data in a number
> of places.

The rest of runqueue initialization doesn't rely on that, and as
a result people might think that it is safe to allocate runqueues
dynamically.

Samuel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/