Re: [PATCH 2.4.32] Fix AVM C4 ISDN card init problems with newer CPUs

From: Willy Tarreau
Date: Fri Aug 04 2006 - 01:16:04 EST


On Thu, Aug 03, 2006 at 06:56:15PM +0100, Alan Cox wrote:
> Ar Iau, 2006-08-03 am 19:53 +0300, ysgrifennodd Jukka Partanen:
> > AVM C4 ISDN NIC: Add three memory barriers, taken from 2.6.7,
> > (they are there in 2.6.17.7 too), to fix module initialization
> > problems appearing with at least some newer Celerons and
> > Pentium III.
>
> Should be using cpu_relax() I think. Its a polled busy loop so you want
> other CPU threads to run if possible.

Agreed, but I think it should be a second patch since 2.6 would need it
too.

> Otherwise the code seems quite logical depending how c4inmeml is defined.

OK, I'm queuing it for 2.4.34.

> Alan

Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/