Re: Futex BUG in 2.6.18rc2-git7

[Thomas Gleixner]

On Fri, 2006-08-04 at 10:36 +0200, Andi Kleen wrote:
> On Friday 04 August 2006 10:26, Olaf Hering wrote:
> > On Fri, Aug 04, 2006 at 09:17:00AM +0200, Andi Kleen wrote:
> > > 
> > > One of my test machines (single socket core2 duo) running 2.6.18rc2-git7 over night 
> > > under moderate load threw this, followed by an endless loop of soft lockup timeouts
> > > (one exemplar appended)
> > > 
> > > I assume it is related to the new PI mutexes.
> > 
> > Maybe triggered by this, if it was from wagner.suse.de:
> 
> Yes it was that box. So it looks like the new mutex code cannot run
> the glibc test suite.

Can you retest against -rc3-current + the compat fix I sent out earlier
today (see also below) ?

Is the glibc the latest CVS version ?

	tglx


diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
index d1aab1a..c5cca3f 100644
--- a/kernel/futex_compat.c
+++ b/kernel/futex_compat.c
@@ -39,7 +39,7 @@ void compat_exit_robust_list(struct task
 {
 	struct compat_robust_list_head __user *head = curr->compat_robust_list;
 	struct robust_list __user *entry, *pending;
-	unsigned int limit = ROBUST_LIST_LIMIT, pi;
+	unsigned int limit = ROBUST_LIST_LIMIT, pi, pip;
 	compat_uptr_t uentry, upending;
 	compat_long_t futex_offset;
 
@@ -59,10 +59,10 @@ void compat_exit_robust_list(struct task
 	 * if it exists:
 	 */
 	if (fetch_robust_entry(&upending, &pending,
-			       &head->list_op_pending, &pi))
+			       &head->list_op_pending, &pip))
 		return;
 	if (upending)
-		handle_futex_death((void *)pending + futex_offset, curr, pi);
+		handle_futex_death((void *)pending + futex_offset, curr, pip);
 
 	while (compat_ptr(uentry) != &head->list) {
 		/*


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/