Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access

From: Shem Multinymous
Date: Sun Aug 06 2006 - 18:44:56 EST


On 8/6/06, Andrew Morton <akpm@xxxxxxxx> wrote:
And I'd say this patch series _is_ substantial because it pokes at
registers which might be described in confidential/NDA'ed documentation, or
in ways which might be derived from $OTHER_OS.

For what it's worth to you:
I hereby declare that this patch was developed solely based on public
specifications, observation of hardware behavior by trial&eror, and
specifications made available to me in clean-room settings and with no
attached obligations. So this patch is as pure as the mainline hdaps
driver it fixes (and probably purer than many other drivers), and not
a single line of it is a derivative work of $OTHER_OS code.

If it would help inspire trust, you can look at the tp_smapi revision
history on sf.net, where many of those trials and errors are
immortalized.

As for the register poking, I believe all the code in thinkpad_ec.c
logically follows from the publicly available H8S documentation (see
link at the top of the sourcecode), except for one number (base port
"0x1600") which is already given by the mainline hdaps driver.

Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/