Re: x86_64 command line truncated II

[Andy Whitcroft]

Andi Kleen wrote:
> Andi Kleen <ak@xxxxxxx> writes:
>
> > Andy Whitcroft <apw@xxxxxxxxxxxx> writes:
> >
> > > It seems that the command line on x86_64 is being truncated during boot:
> > in mm right?
> > > Will try and track it down.
> > Don't bother, it is likely "early-param" (the patch from
> > hell). I'll investigate.
>
> Following up myself ... 
>
> Are you sure it's a regression? 2.6.17 does the same
> and we always had that 255 character limit (I tried 
> to increase it once, but it broke some old lilo setups) 
>
> i386 should be the same btw.

Its not being truncated at 255 characters, its being truncated at the 
first space.  This is coming out of parse_args, which dumps '\0's into 
the command_line as it rips it apart.  We now only have one copy of the 
command line (in x86_64) instead of two, so we now expose this trashed 
copy in /proc/cmdline.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/