Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access

[Pavel Machek]

On Mon 2006-08-07 16:23:30, Greg KH wrote:
> On Tue, Aug 08, 2006 at 01:15:57AM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > > Thanks for the sign-offs!
> > 
> > No problem.
> > 
> > > >> +module_param_named(debug, tp_debug, int, 0600);
> > > >> +MODULE_PARM_DESC(debug, "Debug level (0=off, 1=on)");
> > > >> +
> > > >> +/* A few macros for printk()ing: */
> > > >> +#define DPRINTK(fmt, args...) \
> > > >> +  do { if (tp_debug) printk(KERN_DEBUG fmt, ## args); } while (0)
> > > >
> > > >Is not there generic function doing this?
> > > 
> > > None that I found. Many drivers do it this way.
> > 
> > linux/kernel.h : pr_debug() looks similar.
> 
> Use dev_dbg() and friends please instead of rolling your own.

Ahha, okay, dev_dbg() looks even better. (But we have pr_debug in
linux/kernel.h; if it should not be used, comment would be nice).

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/