Re: [PATCH 2/9] sector_t format string

From: Jeff Garzik
Date: Thu Aug 10 2006 - 10:24:27 EST


Roman Zippel wrote:
Hi,

On Thu, 10 Aug 2006, Jeff Garzik wrote:

With CONFIG_LBD, 32-bit machines can already support large block
devices.

If you feel that hardcoding u64 as sector numbers will mean ext4 suddenly
fails on 32-bit, you misunderstand the situation completely.

With CONFIG_LBD disabled you still had the truncation/complexity issues somewhere else, so you gain nothing, but waste memory in ext4.

You gain simplicity and reduced number of code paths.

"waste memory" is hardly a significant argument. I doubt you will notice a difference.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/