Re: [PATCH try #2] fuse: fix error case in fuse_readpages

[David Howells]

Andrew Morton <akpm@xxxxxxxx> wrote:

> > Don't let fuse_readpages leave the @pages list not empty when exiting
> > on error.
> > 
> 
> Oh dear.  read_cache_pages_release_page() is not a readahead thing.  It is
> a dhowells fscache thing.

The pages passed to read_cache_pages() may already be marked with metadata
information (such as to-be-cached marks from NFS or AFS calling FS-Cache), so
we can't just ditch the pages on an error, we have to clean them up properly.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/