Re: [PATCH 3/6] ehea: queue management

[Thomas Klein]

Anton Blanchard wrote:
> Hi,
>
>   
> > --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c	1969-12-31 
> >     
>
>   
> > +static void netdev_get_pauseparam(struct net_device *dev,
> > +				  struct ethtool_pauseparam *pauseparam)
> > +{
> > +	printk("get pauseparam\n");
> > +}
> >     
>
> There are a number of stubbed out ethtool functions like this. Best not
> to implement them and allow the upper layers to return a correct error.
>
> Anton
>   
I agree, stubbs were removed.

Thomas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/