Re: [PATCH] Fix potential deadlock in mthca

[Ingo Molnar]

On Fri, 2006-08-11 at 09:15 -0700, Arjan van de Ven wrote:
> Roland Dreier wrote:
> > Here's a long-standing bug that lockdep found very nicely.
> > 
> > Ingo/Arjan, can you confirm that the fix looks OK and I am using
> > spin_lock_nested() properly?  I couldn't find much documentation or
> > many examples of it, so I'm not positive this is the right way to
> > handle this fix.
> > 
> 
> looks correct to me;
> 
> Acked-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>

looks good to me too.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

btw., we could introduce a new spin-lock op: 

	spin_lock_double(l1, l2);
	...
	spin_unlock_double(l1, l2);

because some other code, like kernel/sched.c, fs/dcache.c and
kernel/futex.c uses quite similar locking.

	Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/