Re: [Ext2-devel] [PATCH 1/9] extents for ext4

[Mingming Cao]

Randy Dunlap wrote:
> > Hi!
> >
> >
> > > > AM> - The existing comments could benefit from some rework by a
> > > > AM> native English speaker.
> > > >
> > > > could someone assist here, please?
> > >
> > > See if this helps.
> > > Patch applies on top of all ext4 patches from
> > > http://ext2.sourceforge.net/48bitext3/patches/latest/.
> >
> > > --- linux-2618-rc4-ext4.orig/include/linux/ext4_fs_extents.h
> > > +++ linux-2618-rc4-ext4/include/linux/ext4_fs_extents.h
> > > @@ -22,29 +22,29 @@
> > > #include <linux/ext4_fs.h>
> > >
> > > /*
> > > - * with AGRESSIVE_TEST defined capacity of index/leaf blocks
> > > - * become very little, so index split, in-depth growing and
> > > - * other hard changes happens much more often
> > > - * this is for debug purposes only
> > > + * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks
> > > + * becomes very small, so index split, in-depth growing and
> > > + * other hard changes happen much more often.
> > > + * This is for debug purposes only.
> > >  */
> > > #define AGRESSIVE_TEST_
> >
> > Using _ for disabling is unusual/nasty. Can't we simply #undef it?
>
>
> Yes, that's the right thing to do.
> The ext4dev people should do that. :)

Okey, I will fixed that. thanks.
> ---
> ~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/