Re: bonding: cannot remove certain named devices

From: Stephen Hemminger
Date: Tue Aug 15 2006 - 19:25:02 EST


On Tue, 15 Aug 2006 15:56:12 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Stephen Hemminger <shemminger@xxxxxxxx>
> Date: Tue, 15 Aug 2006 15:44:44 -0700
>
> > IMHO idiots who put space's in filenames should be ignored. As long
> > as the bonding code doesn't throw a fatal error, it has every right
> > to return "No such device" to the fool.
>
> I agree that whitespace in device names push the limits of sanity.
>
> But if we believe that, we should enforce it in dev_valid_name().
>
> Does anyone really mind if I add the whitespace check there?

That is a good idea since it protects other interfaces from possible problems.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/