Re: [RFC][PATCH 2/7] UBC: core (structures, API)

From: Kirill Korotaev
Date: Thu Aug 17 2006 - 07:41:03 EST


+struct user_beancounter
+{
+ atomic_t ub_refcount;


Why not use a struct kref here instead of rolling your own reference
counting logic?

We need more complex decrement/locking scheme than krefs
provide. e.g. in __put_beancounter() we need
atomic_dec_and_lock_irqsave() semantics for performance optimizations.

Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/