Re: R: How to avoid serial port buffer overruns?

[Robert Hancock]

Giampaolo Tomassoni wrote:
> I beg your pardon: I'm not used that much to interrupts handling in Linux, but this piece of code from sound/drivers/serial-u16550.c in a linux-2.6.16:
>
> 	static irqreturn_t snd_uart16550_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> 	{
> 	        snd_uart16550_t *uart;
> 	
> 	        uart = (snd_uart16550_t *) dev_id;
> 	        spin_lock(&uart->open_lock);
> 	        if (uart->filemode == SERIAL_MODE_NOT_OPENED) {
> 	                spin_unlock(&uart->open_lock);
> 	                return IRQ_NONE;
> 	        }
> 	        inb(uart->base + UART_IIR);             /* indicate to the UART that the interrupt has been serviced */
> 	        snd_uart16550_io_loop(uart);
> 	        spin_unlock(&uart->open_lock);
> 	        return IRQ_HANDLED;
> 	}
>
> means to me that IRQ_HANDLED is returned even when the interrupt is not issued by the specific UART. This may lead to problems when two or more uarts share the same irq line and the irq line is edge-triggered instead of level-triggered, as is the case with ISA.
>
> To my knowledge, IRQ_HANDLED should be returned when an interrupt had been served by that specific device handler. Returning a IRQ_HANDLED when the device didn't request for service, in the best case cuases interrupt latencies, in the worst (like in an ISA environment) impairs servicing requests from devices sharing the same IRQ line.
>
> The byte returned from inb(uart->base + UART_IIR) can be used to detect if this is the requesting UART.
>
> Am I wrong?

IRQ_HANDLED vs. IRQ_NONE has no effect on what interrupt handlers are 
called, etc. It is only used to detect if an interrupt is firing without 
being handled by any driver, in this case the kernel can detect this and 
disable the interrupt.

I'm not sure exactly why the driver is returning IRQ_HANDLED all the 
time, but edge-triggered interrupts are always tricky and there may be a 
case where it can't reliably detect this. Returning IRQ_HANDLED is the 
safe thing to do if you cannot be sure if your device raised an 
interrupt or not.

--
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@xxxxxxxxxxxxx
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/