Re: [PATCH 2/6] BC: beancounters core (API)

[Kirill Korotaev]

Andi Kleen wrote:
> On Wednesday 23 August 2006 13:03, Kirill Korotaev wrote:
>
>
> > +#ifdef CONFIG_BEANCOUNTERS
> > +extern struct hlist_head bc_hash[];
> > +extern spinlock_t bc_hash_lock;
>
>
> I wonder who pokes into that hash from other files? Looks a bit dangerous.
it was kernel/ub/proc.c with proc interface :)
however, we removed it from this patchset version, but forgot extern's...

will remove

> > +void __put_beancounter(struct beancounter *bc);
> > +static inline void put_beancounter(struct beancounter *bc)
> > +{
> > +	__put_beancounter(bc);
> > +}
>
>
> The wrapper seems pointless too.
yep, almost the same reason :)

> The file could use a overview comment what the various counter
> types actually are.
you mean comment about what resource parameters we introduce?
ok, will add it with each resource patch.

> > +	bc_print_id(bc, uid, sizeof(uid));
> > +	printk(KERN_WARNING "BC %s %s warning: %s "
>
>
> Doesn't this need some rate limiting? Or can it be only triggered
> by code bugs?
only due to code bugs.

> > +	bc = &default_beancounter;
> > +	memset(bc, 0, sizeof(default_beancounter));
>
>
> You don't trust the BSS to be zero? @)
:))

Kirill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/