Re: [RFC][PATCH 0/4] Redesign cpu_hotplug locking.

[Gautham R Shenoy]

On Thu, Aug 24, 2006 at 12:34:12PM +0200, Ingo Molnar wrote:
> Please add the appropriate lock_acquire()/lock_release() calls into the 
> new sleeping semaphore type. Just use the parameters that rwlocks use:
> 
> #define rwlock_acquire(l, s, t, i)            lock_acquire(l, s, t, 0, 2, i)
> #define rwlock_acquire_read(l, s, t, i)       lock_acquire(l, s, t, 2, 2, i)
 
> and lockdep will allow recursive read-locking. You'll also need a 
> lockdep_init_map() call to register the lock with lockdep. Then your 
> locking scheme will be fully checked by lockdep too. (with your current 
> code the new lock type is not added to the lock dependency graph(s))

I'm on it. :)

Thanks
ego
-- 
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/