Re: [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix

[Andi Kleen]

On Thursday 24 August 2006 12:58, Paul Jackson wrote:
> From: Paul Jackson <pj@xxxxxxx>
> 
> The x86_64 crosstool build was failing due to:
> 
>   kernel/built-in.o(.smp_altinstructions+0x58): \
>     include/asm/spinlock.h:54: undefined reference to `X86_FEATURE_UP'
> 
> This reference to X86_FEATURE_UP was added to the definition of
> the alternative_smp() macro in alternative.h by the patch:
>   x86_64-mm-fix-x86-cpuid-keys-used-in-alternative_smp
> 
> The alternative_smp() macro is used in spinlock.h.
> 
> The definition of X86_FEATURE_UP is in asm-x86_64/cpufeature.h.
> If this is included in alternative.h, then the build succeeds.

Ok it seems to depend on the .config, but nobody before submitted 
the buggy .config

I folded the patch in

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/