Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]

From: Arnd Bergmann
Date: Mon Aug 28 2006 - 07:50:23 EST


On Friday 25 August 2006 22:18, David Howells wrote:
> > > +ifeq ($(CONFIG_MMU),y)
> > > +obj-y                      += bounce.o
> > > +endif
> >
> > CONFIG_MMU is a bool so you can do this much more elegant:
> > obj-$(CONFIG_MMU) += bounce.o
>
> In patch 18/18, this changes to:
>
>         ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy)
>
> So the elegence in the end is irrelevant.

You could write it as

bounce-$(CONFIG_MMU) += bounce.o
obj-$(CONFIG_BLOCK) += $(bounce-y)

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/