Re: [RFT] sched.h removal from module.h

[Christoph Hellwig]

On Tue, Aug 29, 2006 at 11:10:27AM +1000, Nick Piggin wrote:
> >This is done by duplicating prototype of wake_up_process() which seems
> >to be the only thing module.h wants.
> 
> This is really ugly, IMO. It makes the code less maintainable, so I don't
> think there is any point in doing it. In this case, we really do want to
> use scheduler functions, so the thing you do in that case is to include
> sched.h, not declare them yourself :(
> 
> If you are particularly concerned about this, just move all those refcount
> inlines into kernel/module.c (they're too big anyway)... then you can drop
> the sched.h include from module.h for free ;)

Agreed.  At least module_put should move out of line.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/