Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]

[Arnd Bergmann]

On Tuesday 29 August 2006 15:47, David Howells wrote:
> Arnd Bergmann <arnd.bergmann@xxxxxxxxxx> wrote:
> 
> > You could write it as
> > 
> > bounce-$(CONFIG_MMU) += bounce.o
> > obj-$(CONFIG_BLOCK)  += $(bounce-y)
> 
> I could, yes, but why?  What does it buy?  I think this:
> 
>         ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy)
>         obj-y += bounce.o
>         endif
> 
> is clearer.

I remember having seen the first one in the kernel before
(e.g. in arch/powerpc/kernel/Makefile), but not the other one.

I agree that it doesn't make much difference at all, but it
would be nice to be consistant.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/