Re: [PATCH 1/2] NOMMU: Set BDI capabilities for /dev/mem and /dev/kmem

[David Howells]

Andrew Morton <akpm@xxxxxxxx> wrote:

> #else
> #define get_unmapped_area_mem NULL
> #endif

Blech.

Of course, I could just declare the new symbols weak, and stick
get_unmapped_area_mem() and mem_bdi in their own file which would be
conditional on !CONFIG_MMU.

> This changes behaviour, doesn't it?

Yes.

>  But only for !CONFIG_MMU kernels?

Yes.  For the moment, nothing in MMU world actually looks at these
capabilities, though perhaps they should.

> Perhaps some additional commentary around this is needed.

Perhaps... or perhaps it should have different capabilities if there's an MMU.

Is doing a private mapping of /dev/mem a valid thing to do anyway, even if
there is an MMU?

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/