Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit(ping)

From: H. Peter Anvin
Date: Wed Aug 30 2006 - 15:30:41 EST


Alon Bar-Lev wrote:

Changing saved_command_line is a modification to all
architectures... They all modify this variable...
So, should I submit a patch to all architectures? How can I test this?


Submit a patch set, with the common changes in one patch and the architecture-specific bits broken out per architecture; that way the individual arch maintainers can look at their piece. Since it's a simple variable rename, it shouldn't be a big deal.

Also for i386 the code is assembly... So I can modify the code to write
into a __init buffer and then kmalloc in setup.c.

Don't do that. Just change the name of the buffer in head.S.

-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/