Re: [PATCH -mm] PM: Add pm_trace switch

[Rafael J. Wysocki]

On Wednesday 30 August 2006 22:33, Greg KH wrote:
> On Wed, Aug 30, 2006 at 10:22:36PM +0200, Rafael J. Wysocki wrote:
> > On Wednesday 30 August 2006 19:22, Greg KH wrote:
> > > On Wed, Aug 30, 2006 at 12:02:59PM +0200, Rafael J. Wysocki wrote:
> > > > On Tuesday 29 August 2006 22:46, Andrew Morton wrote:
> > > > > On Tue, 29 Aug 2006 13:09:57 +0200
> > > > > "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> > > > > 
> > > > > > +int pm_trace_enabled;
> > > > > > +
> > > > > > +static ssize_t pm_trace_show(struct subsystem * subsys, char * buf)
> > > > > > +{
> > > > > > +	return sprintf(buf, "%d\n", pm_trace_enabled);
> > > > > > +}
> > > > > > +
> > > > > > +static ssize_t
> > > > > > +pm_trace_store(struct subsystem * subsys, const char * buf, size_t n)
> > > > > > +{
> > > > > > +	int val;
> > > > > > +
> > > > > > +	if (sscanf(buf, "%d", &val) == 1) {
> > > > > > +		pm_trace_enabled = !!val;
> > > > > > +		return n;
> > > > > > +	}
> > > > > > +	return -EINVAL;
> > > > > > +}
> > > > > > +
> > > > > > +power_attr(pm_trace);
> > > > > 
> > > > > <grumbles about documentation>
> > > > 
> > > > Well, this is the most difficult part. ;-)
> > > > 
> > > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > > > ---
> > > >  Documentation/power/interface.txt |   15 +++++++++++++++
> > > 
> > > Please update Documentation/ABI/ too.
> > 
> > I could, but there's nothing related to /sys/power/ in Documentation/ABI/
> > right now.
> > 
> > Do you mean I should create a file for /sys/power/ in there?  If so, what
> > should I put in there?  I guess pretty much the same as in
> > Documentation/power/interface.txt ...
> 
> Exactly :)

Okay, but I think that should be done in a separate patch.

Greetings,
Rafael


-- 
You never change things by fighting the existing reality.
		R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/