Re: cpu_init is called during resume

[Pavel Machek]

Hi!

> >cpu_init() is called during resume, at time when GFP_KERNEL is not
> >available. This silences warning, and adds few small cleanups.
> >  
> 
> I presume this is resume from disk.  If you're doing resume from RAM, 
> all the CPU-related stuff should already be allocated, unless you're 
> bringing up a new CPU which wasn't previously there, right?

We are doing virtual cpu hotplug/unplug... actually suspend to RAM
*and* disk. Just try it :-).

> And wouldn't making these allocations atomic make real CPU hotplug (ie, 
> on an active, running system) more likely to fail?  This code doesn't 
> deal with allocation failure very elegantly.

Hmm... well hopefully free_pages_min will cover this case.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/