Re: [Bug ??] 2.6.18-rc6-mm2 - PCI ethernet board does not seem to work

From: Matt Domsch
Date: Fri Sep 15 2006 - 17:44:14 EST


On Fri, Sep 15, 2006 at 03:29:54AM -0700, Greg KH wrote:
> That being said, I think we need to reverse the order of this patch,
> keeping the current scheme as default, and allowing it to be overridden
> on the command line for those few machines where it matters to be
> compatible with the old, 2.4 ordering scheme.
>
> Matt, care to rework the patch in this manner?

Greg, Andrew,

I'd really like to rework this patch in a different direction. As
such, please drop the patch:

gregkh-pci-pci-sort-device-lists-breadth-first.patch

from your trees, and I'll provide a new one next week.

Breadth-first vs depth-first is really only part of the problem. More
fundamental is the expectation that embedded devices get discovered
before add-in devices in physical slots. From there, breadth-first vs
depth-first is interesting again. I'd like to sort the list to put
the embedded devices first, subsort those breadth-first, then list the
add-in devices in ascending slot number order, subsort breadth-first.
I'll default this sorting routine off, enabled/disabled via a command
line option, and enabled by default for some systems based on DMI
strings.

arch/i386/pci/irq.c already has the PCI IRQ Routing Table available,
from which we can get embedded vs slotN information. It's not
currently being used in this manner, so I'm massaging that.

How does this sound?

Thanks,
Matt

--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

Attachment: pgp00000.pgp
Description: PGP signature