Re: [PATCH] mxser: PCI refcounts

[Jiri Slaby]

Jiri Slaby wrote:
> Alan Cox wrote:
> > Switch to pci ref counts for mxser when handling PCI devices. Use
> > pci_get_device and drop the reference when we finish and unload.
>
> Please, don't do that. These all drivers need to be rewritten to pci 
> probing (for this one I have a patch, but I waited for confirmation of 
> previous patchset, but nothing has come, so perhaps I will clone it as 
> NEW/EXPERIMENTAL 1.9.1-with-pci-probing-driver) and when pci_find_device 
> is there, we can `grep -r` it to know, which drivers need that. The same 

Just a note. I tried to do all this work, but it was nacked:
http://www.fi.muni.cz/~xslaby/unpr/linux_patches/pci_find/

You can pick up from there some patches for non-device drivers (such as buses or 
so), if you want to not do the work yourself again...

regards,
--
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/