Re: [patch] kprobes: optimize branch placement

[Andrew Morton]

On Sat, 16 Sep 2006 22:29:39 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

> --- linux.orig/arch/i386/kernel/kprobes.c
> +++ linux/arch/i386/kernel/kprobes.c
> @@ -220,7 +220,7 @@ int __kprobes kprobe_handler(struct pt_r
>  	kcb = get_kprobe_ctlblk();
>  
>  	/* Check we're not actually recursing */
> -	if (kprobe_running()) {
> +	if (unlikely(kprobe_running())) {
>  		p = get_kprobe(addr);

This function does two calls to get_kprobe() (in the recurring-trap case)
where only one is needed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/