Re: tracepoint maintainance models

[Mathieu Desnoyers]

* Ingo Molnar (mingo@xxxxxxx) wrote:
> Karim, i dont usually reply if you insult me (and you've grown a habit 
> of that lately ), but this one is almost parodic. To understand my 
> point, please consider this simple example of a static in-source markup, 
> to be used by a dynamic tracer:
> 
>   static int x;
> 
>   void func(int a)
>   {
>        ...
>        MARK(event, a);
>        ...
>   }
> 
> if a dynamic tracer installs a probe into that MARK() spot, it will have 
> access to 'a', but it can also have access to 'x'. While a static 
> in-source markup for _static tracers_, if it also wanted to have the 'x' 
> information, would also have to add 'x' as a parameter:
> 
> 	MARK(event, a, x);
> 

Hi,

If I may, if nothing marks the interest of the tracer in the "x" variable, what
happens when a kernel guru changes it for y (because it looks a lot better). The
code will not compile anymore when the markup marks the interest for x, when
your "dynamic tracer" markup will simply fail to find the information. My point
is that the markup of the interesting variables should follow code changes,
otherwise it will have to be constantly updated elsewhere (hmm ? Documentation/
someone ?)

I would say that not marking a static variable just because it is less visually
intrusive is a not such a good thing to do. That's not because we *can* that we
*should*.

Mathieu

OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/