Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flashcard readers

[Pierre Ossman]

Alex Dubov wrote:
> I was looking at the way to put my driver into the kernel and currently have three ways of doing
> it (all of them came up in the thread, already):
> 1.
> Put everything in drivers/misc
>
> 2.
> Put tifm_core, tifm_7xx1 and tifm_ms (in progress) in drivers/misc, tifm_sd in drivers/mmc
>
> 3.
> Put everything in drivers/mmc
>
> I'm favoring everything in drivers/mmc, especially if it can be renamed into drivers/flashcards or
> something. This way, all flash card drivers will be nicely localized. In this respect, I also
> wonder where the MemoryStick driver for Winbond card readers is supposed to go when it enters the
> kernel? (Winbond driver is written by people with access to the MemoryStick spec and I'm using it
> as reference for my own work, with great utility).
>
>   

I prefer 2, where only tifm_sd (and tifm_ms) show up in Kconfig. The
other modules will be "Select":ed via Kconfig.

1 can be a bit confusing for users as they expect a MMC/SD driver to be
in drivers/mmc, but it could be acceptable if it's considered more
important to keep all files in a common place.

3 is out as drivers/mmc isn't for "any flashcard technology". It is
intended to grow with SDIO drivers, so we do not want to clutter it up
with other systems.

Until your (and Winbond's) driver has a generic MemoryStick layer, then
the fact that you use MemoryStick is just an implementation detail. From
the kernel's point of view you're just some odd-ball block driver. When
we have a generic MS layer, we should probably move these to a "ms"
directory, possibly creating a common tree structure for mmc and ms.

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/