RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

[Zang Roy-r61911]

> 
> I have some review comments about your driver; please 
> consider them for
> fixing....
> 
Thanks.
> 
> > +		spin_unlock_irq(&phy_lock);
> > +		msleep(10);
> > +		spin_lock_irq(&phy_lock);
> > +	}
> 
> hmm some places take phy_lock with disabling interrupts, while others
> don't. I sort of fear "the others" may be buggy.... are you sure those
> are ok?
Could you interpret your comments in detail?
Roy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/