Re: [Patch03/05]- Containers: Initialization and Configfs interface

From: Rohit Seth
Date: Tue Sep 19 2006 - 12:33:57 EST


On Tue, 2006-09-19 at 11:38 -0400, Valdis.Kletnieks@xxxxxx wrote:
> On Thu, 14 Sep 2006 18:41:26 PDT, Rohit Seth said:
>
> > --- linux-2.6.18-rc6-mm2.org/kernel/container_configfs.c 1969-12-31 16:00:00.000000000 -0800
> > +++ linux-2.6.18-rc6-mm2.ctn/kernel/container_configfs.c 2006-09-14 16:18:45.000000000 -0700
>
> > +static ssize_t simple_containerfs_attr_show(struct config_item *item,
> > + struct configfs_attribute *attr,
> > + char *page)
> ...
> > + switch (ctfs_attr->idx) {
> > + case CONFIGFS_CTN_ATTR_ID:
> > + tmp = sc->ctn.id;
> > + break;
> ...
> > + return sprintf(page, "%ld\n", tmp);
>
> What use is this value, given that we already have containers/user_friendly_name
> to use in the filesystem namespace? Or is this a mostly-debugging thing?

I think ids (numeric numbers) will be useful when printing the
information in /proc/<pid>/container User land tools don't necessarily
have to parse the (name) string in that case.

-rohit

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/