Re: [PATCH] rtc: lockdep fix

[Arjan van de Ven]

Ingo Molnar wrote:
> * Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
>
> > BUG: warning at kernel/lockdep.c:1816/trace_hardirqs_on() (Not tainted)
> >  [<c04051ee>] show_trace_log_lvl+0x58/0x171
> >  [<c0405802>] show_trace+0xd/0x10
> >  [<c040591b>] dump_stack+0x19/0x1b
> >  [<c043abee>] trace_hardirqs_on+0xa2/0x11e
> >  [<c06143c3>] _spin_unlock_irq+0x22/0x26
> >  [<c0541540>] rtc_get_rtc_time+0x32/0x176
> >  [<c0419ba4>] hpet_rtc_interrupt+0x92/0x14d
> >  [<c0450f94>] handle_IRQ_event+0x20/0x4d
> >  [<c0451055>] __do_IRQ+0x94/0xef
> >  [<c040678d>] do_IRQ+0x9e/0xbd
> >  [<c0404a49>] common_interrupt+0x25/0x2c
>
> ouch! That is a scenario that could lead to real lockups. Fix looks good 
> and necessary for v2.6.18 to me.

btw this entire code path is evil; the rtc_get_rtc_time() function can do really long delays
which is unsuitable for being called in interrupt context!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/