Re: [patch] mspec driver

[Randy.Dunlap]

On 20 Sep 2006 03:26:53 -0400 Jes Sorensen wrote:

Ahoy.

>  drivers/char/Kconfig  |    8 
>  drivers/char/Makefile |    1 
>  drivers/char/mspec.c  |  421 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 430 insertions(+)
> 
> Index: linux-2.6/drivers/char/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/char/Kconfig
> +++ linux-2.6/drivers/char/Kconfig
> @@ -439,6 +439,14 @@ config SGI_MBCS
>           If you have an SGI Altix with an attached SABrick
>           say Y or M here, otherwise say N.
>  
> +config MSPEC
> +	tristate "Memory special operations driver"
> +	depends on IA64
> +	help
> +	  If you have an ia64 and you want to enable memory special
> +	  operations support (formerly known as fetchop), say Y here,
> +	  otherwise say N.

If the answers are {Y, N}, then it should be bool instead of tristate.
If tristate, M can be an answer....

>  source "drivers/serial/Kconfig"
>  
>  config UNIX98_PTYS

> Index: linux-2.6/drivers/char/mspec.c
> ===================================================================
> --- /dev/null
> +++ linux-2.6/drivers/char/mspec.c
> @@ -0,0 +1,421 @@
> +#include <linux/config.h>

Don't need to include config.h (it's done by build system).
(well, actually autoconf.h is)

> +static struct vm_operations_struct mspec_vm_ops = {
> +	.open = mspec_open,
> +	.close = mspec_close,
> +	.nopfn = mspec_nopfn
> +};

These interfaces create a userspace interface, eh?
So those 3 functions could stand to have kernel-doc function
comments and have documentation in Documentation/ABI/ (see its
README file for more details).  Maybe check all of
Documentation/SubmitChecklist for other items...

> +/*
> + * mspec_init
> + *
> + * Called at boot time to initialize the mspec facility.
> + */
> +static int __init
> +mspec_init(void)

ugh, matey.  All on one line.

> +{
> +}
> +
> +static void __exit
> +mspec_exit(void)

Ditto.

> +{
> +}

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/