Re: [patch] do_no_pfn()

From: Jes Sorensen
Date: Wed Sep 20 2006 - 12:49:30 EST


Randy.Dunlap wrote:
On 20 Sep 2006 03:25:25 -0400 Jes Sorensen wrote:
+#define NOPFN_SIGBUS ((unsigned long) -1)
+#define NOPFN_OOM ((unsigned long) -2)

Is there any difference in the above and

#define NOPFN_SIGBUS -1UL
#define NOPFN_OOM -2UL

I don't think there is, but I was trying to keep it consistent with the
NOPAGE_foo versions - the way it's done is more explicit so less likely
anyone will get confused over it.

I can change it if it's a sticking point, but I'd claim thats more noise
than it's worth.

Thanks,
Jes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/