Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18

[Alan Cox]

Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> Hi,
> 
> This is the serial driver for Blackfin. It is designed for the serial
> core framework.

> +#define DMA_RX_XCOUNT		TTY_FLIPBUF_SIZE

TTY_FLIPBUF_SIZE is going away. Just pick a value good for your hardware
and under PAGE_SIZE.

Other question - is your locking ok for low latency. In low latency mode
tty_flip_buffer_push() may directly end up calling your write methods.

Otherwise looks good

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/