Re: [PATCH 4/4] therm_throt: Add a cumulative thermal throttle event counter.

[Andi Kleen]

> +	preempt_disable();         /* CPU hotplug */
> +	for_each_online_cpu(cpu) {
> +		/* connect live CPUs to sysfs */
> +		thermal_throttle_add_dev(get_cpu_sysdev(cpu));
> +	}
> +	preempt_enable();

There was still one problem in there: sysfs_create_group can 
sleep and that's not ok with preemption disabled.

I changed it to register the notifier first and do the necessary
locking in there using a private lock (that the new akpm-recommended(tm)
way to do this) 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/