Re: ioremap balanced with iounmap for drivers/mtd subsystem

[Francois Romieu]

Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> :
> commit 25f0c659fe64832d8ee06aa623fffaad708dcf8b
[...]
> diff --git a/drivers/mtd/maps/arctic-mtd.c b/drivers/mtd/maps/arctic-mtd.c
> index d95ae58..642d96b 100644
> --- a/drivers/mtd/maps/arctic-mtd.c
> +++ b/drivers/mtd/maps/arctic-mtd.c
> @@ -96,6 +96,8 @@ static struct mtd_partition arctic_parti
>  static int __init
>  init_arctic_mtd(void)
>  {
> +	int err = 0;

Unneeded initialization.

> @@ -109,12 +111,20 @@ init_arctic_mtd(void)
>  	printk("%s: probing %d-bit flash bus\n", NAME, BUSWIDTH * 8);
>  	arctic_mtd = do_map_probe("cfi_probe", &arctic_mtd_map);
>  
> -	if (!arctic_mtd)
> +	if (!arctic_mtd) {
> +		iounmap((void *) arctic_mtd_map.virt);

Useless cast.

These two patterns are repeated all over the patch.

A grep for iounmap in drivers/mtd/nand would not hurt.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/