Re: [PATCH -mm 0/6] swsusp: Add support for swap files

[Nigel Cunningham]

Hi.

On Sun, 2006-09-24 at 00:18 +0200, Rafael J. Wysocki wrote:
> > > We could use a regular (non-swap) file like this but that would require us to
> > > use some dangerous code (ie. one that writes directly to blocks belonging to
> > > certain file bypassing the filesystem).  IMHO this isn't worth it, provided
> > > the kernel's swap-handling code can do this for us and is known to work. ;-)
> > 
> > It's not that dangerous once you debug it.
> 
> Certainly.  Still, let me repeat: if there is some code that does pretty much
> the same and has _already_ been debugged, I prefer using it to writing some
> new code, debugging it etc.

Look at Suspend2 then. I know you won't want it in exactly that form,
but it's there and have been tested and debugged.

> > This is what Suspend2 does - 
> > all I/O is done using bmapping and bios with direct sector numbers,
> > regardless of where you're reading from/writing to. The main difficulty
> > I saw was with XFS, where the device block size and filesystem block
> > size can differ, but even then, it's just a matter of making sure you
> > get the right one in the right place.
> > 
> > I would encourage you in this direction because it also adds way more
> > flexibility. If swap is a thing of the past, the only reason for people
> > to have swap space now is to suspend to disk. If you can write to a swap
> > file, they don't need a swap partition and more.
> 
> Obviously.  That's what the patches are for. :-)
> 
> > If you can write to an 
> > ordinary file, they can know that even if they are in a low memory
> > situation and swap is being used, there's no race condition between
> > freeing up memory to meet the conditions for suspending to disk, and
> > allocating storage for writing the actual image.
> 
> Well, I wouldn't call that a race condition.

You want to write the image to swap (any kind) but you need to use swap
to free up enough memory so that you can make the image and write it.
But wait, in freeing enough memory, you reduced the amount of swap
available for your image, so now you need to free more...

> By using an ordinary file to save the suspend image, you effectively divide
> the whole storage needed for suspending in two independent parts.  Still
> the sum of these two parts has to be sufficient to save the total amount of
> data that cannot be discarded residing in memory before the suspend.  IMO
> it doesn't really matter if this storage is divided or not, because to total
> size of it has to be sufficient regardless.

You're forgetting, I think, that for Suspend2, we're not usually
swapping anything out. It would only be under very unusual memory load
that we'd be swapping memory out, and that would only be after caches
were discarded, which would probably address the situation itself.
There's therefore no division of the image.

Regards,

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/