Re: [patch 1/2] libata: _GTF support

[Kristen Carlson Accardi]

On Fri, 29 Sep 2006 03:07:07 +0100
Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:

> On Thu, Sep 28, 2006 at 11:29:01AM -0700, Kristen Carlson Accardi wrote:
> 
> I mentioned this to Randy a while back, but I can't remember what sort 
> of resolution we came to. In any case:
> 
> > + * sata_get_dev_handle - finds acpi_handle and PCI device.function
> 
> I'm a bit uncomfortable that we seem to have two quite different ways of 
> accomplishing much the same thing. On the PCI bus, we have a callback 
> that gets triggered whenever a new PCI device is attached. At that 
> point, we look for the associated ACPI object and put a pointer to that 
> in the device structure. Then, whenever we want to make an ACPI call, we 
> can simply refer to that.
> 
> This implementation seems to reimplement much of the same lookup code, 
> but makes it libata specific. Wouldn't it be cleaner to implement it in 
> a similar way to PCI? The only real downside is that you need to add a 
> callback in the ata bus code. drivers/pci/pci-acpi.c/pci_acpi_init is 
> the sort of thing required.
> 
> (Thinking ahead, would that make it easier to maintain links in sysfs 
> between devices and acpi objects?)
> 
> -- 
> Matthew Garrett | mjg59@xxxxxxxxxxxxx

This makes sense to me.  I'm happy to put together some patches for 
commenting on if people think this is a good way to go.  It would be
much cleaner in my opinion and we could get rid of a good chunk of code.

Kristen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/