Re: [PATCH 12/12] i386 boot: Add an ELF header to bzImage

[Vivek Goyal]

On Fri, Oct 06, 2006 at 02:54:12PM -0700, H. Peter Anvin wrote:
> Eric W. Biederman wrote:
> >"H. Peter Anvin" <hpa@xxxxxxxxx> writes:
> >
> >>Vivek Goyal wrote:
> >>>Hi Eric,
> >>>I have added cld in the regenerated patch below.
> >>No, the cld needs to be earlier.  It turns out this isn't the first use of
> >>string instructions.
> >
> >Can we rely on the int calls not setting df?  Otherwise we need to clear
> >df at each use as we do with all of the later uses.
> >
> 
> Yes, we can, with a few exceptions.  INT saves the flags and IRET 
> restores them.
>

Ok. I have added the "cld" early in the setup code. I am still retaining
the call to "cld" just before string instruction to be on the safer side.

Please find attached the regenerated patch.



In the lazy programmer school of fixes.

I haven't really tested this in any configuration.
But reading video.S it does use variable in the bootsector.
It does seem to initialize the variables before use.
But obviously something is missed.

By zeroing the uninteresting parts of the bootsector just after we
have determined we are loaded ok.  We should ensure we are
always in a known state the entire time. 

Andrew if I am right about the cause of your video not working
when you set an enhanced video mode this should fix your boot
problem.

Singed-off-by: Eric Biederman <ebiederm@xxxxxxxxxxxx>

Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
---

 linux-2.6.19-rc1-vivek/arch/i386/boot/setup.S |   12 ++++++++++++
 1 files changed, 12 insertions(+)

diff -puN arch/i386/boot/setup.S~i386-set-bootset-to-zero-fix arch/i386/boot/setup.S
--- linux-2.6.19-rc1/arch/i386/boot/setup.S~i386-set-bootset-to-zero-fix	2006-10-09 10:11:58.000000000 -0400
+++ linux-2.6.19-rc1-vivek/arch/i386/boot/setup.S	2006-10-09 10:27:42.000000000 -0400
@@ -167,6 +167,7 @@ trampoline:	call	start_of_setup
 # End of setup header #####################################################
 
 start_of_setup:
+	cld 				# set DF=0
 # Bootlin depends on this being done early
 	movw	$0x01500, %ax
 	movb	$0x81, %dl
@@ -287,6 +288,17 @@ good_sig:
 loader_panic_mess: .string "Wrong loader, giving up..."
 
 loader_ok:
+# Zero initialize the variables we keep in the bootsector
+	movw	%cs, %ax			# aka SETUPSEG
+	subw	$DELTA_INITSEG, %ax		# aka INITSEG
+	movw	%ax, %es
+	xorw	%di, %di
+	xorb	%al, %al
+	movw	$497, %cx
+	cld
+	rep
+	stosb
+
 # Get memory size (extended mem, kB)
 
 	xorl	%eax, %eax
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/