Re: Why is device_create_file __must_check?

[Andrew Morton]

On Tue, 10 Oct 2006 15:14:04 +1000
Paul Mackerras <paulus@xxxxxxxxx> wrote:

> > Because it can fail.  We need to take _some_ action if the setup failed - at
> > least report it so the user (and the kernel developers) know that something
> > is going wrong.
> 
> So we have to add printks in all sorts of places where the
> device_create_file has never failed before.  If you're that concerned,

aren't you concerned too?

> why not add a WARN_ON(error) in device_create_file() ?

That might be suitable, yup.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/