Re: [ckrm-tech] [PATCH 0/5] Allow more than PAGESIZE data read inconfigfs
From: Paul Jackson
Date: Thu Oct 12 2006 - 17:44:51 EST
> And what if you decide to
> change it from "<pid>\n" to "<pid> <tgid>\n" per line?
I think that's a good argument for never changing the format of one
of these files, rather than a good argument for against a vector of
scalars of identical type and purpose.
And I'd agree that we should not use multiple values per file to
represent a structure either - so I'd agree that we should not allow
"<pid> <tgid>\n" in the first place.
In the cpuset file system:
1) There is one value, or one vector of equivalent scalar values, per file.
2) Once released into the wild, a file never changes what it does or how
it looks.
3) It's ok to add new files.
4) But, at least in the case of cpusets, not ok to add directories, as
the file system represents one directory per one cpuset. No other
directories not representing cpusets are allowed.
This configfs flap feels to me like someone slightly overgeneralized
the lesson to be learned from previous problems displaying entire,
evolving, structures in a single file, and then is being a bit over
zealous enforcing the resulting rule.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/