Re: [PATCH] i386 Time: Avoid PIT SMP lockups

[Andi Kleen]

Andrew Morton <akpm@xxxxxxxx> writes:
> 
> Is there any actual need to hold xtime_lock while doing the port IO?  I'd
> have thought it would suffice to do
> 
> 	temp = port_io
> 	write_seqlock(xtime_lock);
> 	xtime = muck_with(temp);
> 	write_sequnlock(xtime_lock);
> 
> ?

That would be a good idea in general. The trouble is just that whatever race
is there will be still there then, just harder to trigger (so instead of 
every third boot it will muck up every 6 weeks). Not sure that is
a real improvement.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/