Re: [Patch 0/3] Driver core: Some probing changes

[Alan Stern]

On Mon, 16 Oct 2006, Cornelia Huck wrote:

> Hi,
> 
> the following patches attempt to fix some issues in the current device
> probing code:
> 
> [1/3] Don't stop probing on ->probe errors.
> [2/3] Change function call order in device_bind_driver().
> [3/3] Per-subsystem multithreaded probing.
> 
> Patches are against -gkh tree. Works for me on s390 and on i386 with
> pci multithreaded probing enabled. (I also enabled multithreaded
> probing on the css and ccw busses in order to test the code on s390,
> but this doesn't make much sense since we already do async device
> recognition, so I'm not sending a patch.)

Your patch 2 looks fine.

Patch 1 is somewhat questionable.  Certainly the log message reporting the
error should be left in.  The other issue is whether to continue with
probing other drivers.  I guess there's no reason not to; stopping short
was merely an optimization.

I'll discuss patch 3 in a separate message.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/