Re: [PATCH] pci: x86-32/64 switch to pci_get API

[Andi Kleen]

On Mon, Oct 16, 2006 at 05:45:13PM +0100, Alan Cox wrote:
> Ar Llu, 2006-10-16 am 18:07 +0200, ysgrifennodd Andi Kleen:
> > > --- linux.vanilla-2.6.19-rc1-mm1/arch/x86_64/kernel/pci-calgary.c	2006-10-13 15:10:06.000000000 +0100
> > > +++ linux-2.6.19-rc1-mm1/arch/x86_64/kernel/pci-calgary.c	2006-10-13 17:14:40.000000000 +0100
> > > @@ -879,7 +879,7 @@
> > >  
> > >  error:
> > >  	do {
> > > -		dev = pci_find_device_reverse(PCI_VENDOR_ID_IBM,
> > > +		dev = pci_get_device_reverse(PCI_VENDOR_ID_IBM,
> > >  					      PCI_DEVICE_ID_IBM_CALGARY,
> > >  					      dev);
> > 
> > No put call anywhere?
> 
> You can't hot unplug your MMU

Not sure about that. Calgary is afaik in the bridges and since Summit
has pluggable PCI cages and nodes i would assume the MMU instances are also
hot pluggables.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/