Re: [RFC: 2.6.19 patch] snd-hda-intel: default MSI to off

[Fatih Asici]

On 10/18/06, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> On Thu, Oct 05, 2006 at 11:08:57PM +0200, Prakash Punnoor wrote:
> > Am Donnerstag 05 Oktober 2006 19:30 schrieb Fatih A????c??:
> > > 2006/10/5, Prakash Punnoor <prakash@xxxxxxxxxx>:
> > > > Hi,
> > > >
> > > > subjects say it all. Without irqpoll my nic doesn't work anymore. I added
> > > > Ingo
> > > > to cc, as my IRQs look different, so it may be a prob of APIC routing or
> > > > the
> > > > like.
> >
> > > > Can you try booting with pci=nomsi ? I have a similar problem with my
> >
> > I used snd-hda-intel.disable_msi=1 and this actually helped! Now the nforce
> > nic works w/o problems. So it was the audio driver causing havoc on the nic.
> >...
>
> Unless someone finds and fixes what causes such problems, I'd therefore
> suggest the patch below to let MSI support to be turned off by default.

What about putting MCP51 to the msi quirk list?


diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 23b599d..75311df 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1716,6 +1716,7 @@ static void __devinit quirk_disable_msi(
      }
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD,
PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA,
PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_BRIDGE, quirk_disable_msi);

/* Go through the list of Hypertransport capabilities and
* return 1 if a HT MSI capability is found and enabled */
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index f069df2..03cb469 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -1146,6 +1146,7 @@ #define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP5
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_IDE  0x0265
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SATA 0x0266
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SATA2        0x0267
+#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_BRIDGE       0x026F
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SMBUS        0x0368
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_IDE  0x036E
#define PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SATA 0x037E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/