Re: [Alsa-devel] [RFC: 2.6.19 patch] snd-hda-intel: default MSI to off

[Takashi Iwai]

At Wed, 18 Oct 2006 10:02:19 -0700,
Stephen Hemminger wrote:
> 
> On Wed, 18 Oct 2006 12:24:54 +0200
> Takashi Iwai <tiwai@xxxxxxx> wrote:
> 
> > At Tue, 17 Oct 2006 14:40:53 -0700,
> > Stephen Hemminger wrote:
> > > 
> > > On Tue, 17 Oct 2006 23:13:01 +0200
> > > Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > > 
> > > > On Thu, Oct 05, 2006 at 11:08:57PM +0200, Prakash Punnoor wrote:
> > > > > Am Donnerstag 05 Oktober 2006 19:30 schrieb Fatih A????c??:
> > > > > > 2006/10/5, Prakash Punnoor <prakash@xxxxxxxxxx>:
> > > > > > > Hi,
> > > > > > >
> > > > > > > subjects say it all. Without irqpoll my nic doesn't work anymore. I added
> > > > > > > Ingo
> > > > > > > to cc, as my IRQs look different, so it may be a prob of APIC routing or
> > > > > > > the
> > > > > > > like.
> > > > > 
> > > > > > > Can you try booting with pci=nomsi ? I have a similar problem with my
> > > > > 
> > > > > I used snd-hda-intel.disable_msi=1 and this actually helped! Now the nforce 
> > > > > nic works w/o problems. So it was the audio driver causing havoc on the nic. 
> > > > >...
> > > > 
> > > > Unless someone finds and fixes what causes such problems, I'd therefore 
> > > > suggest the patch below to let MSI support to be turned off by default.
> > > > 
> > > > cu
> > > > Adrian
> > > > 
> > > 
> > > It shouldn't be that hard to write a small bit of code to force an interrupt
> > > and catch it, that's what other drivers do to workaround the BIOS braindamage
> > > that seems to be rampant (until M$ Vista comes out and supports MSI).
> > 
> > OK, what about a patch like below?
> > 
> > It's against the latest ALSA tree, so please pull alsa.git from
> > 	git://kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> > before applying it (this tree includes only patches to be pushed to
> > 2.6.19).
> > 
> > 
> > Takashi
> > 
> 
> Don't you need to check return value from pci_enable_msi()?

Yes, it would be better to check the value and reset chip->msi if
not successful.  But it's not a fatal error, so the current code
should work.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/