Re: 2.6.19-rc2-mm1

From: Nick Piggin
Date: Wed Oct 18 2006 - 14:32:00 EST


Nick Piggin wrote:

I can't see anything yet, but I'll keep looking (and try to reproduce
if I can get TLP working).

Ah, it is probably exercising the -EFAULT path, and the code in
Andrew's tree goes into an infinite loop I think.

We can't test for a fault off the atomic copy, because that needn't
indicate an unmapped area. What we need to do is change
fault_in_pages_readable to return ret, and catch and return that
in the caller if it is an error.

My usual workstation is down ATM otherwise I would send you a patch.
Unless someone beats me to it, I'll send you one tomorrow.

Thanks,
Nick

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/