Re: 2.6.19-rc2-mm1

[Andrew Morton]

On Wed, 18 Oct 2006 22:26:50 +0200
Cedric Le Goater <clg@xxxxxxxxxx> wrote:

> > Because we must service a fault if it happens here. The
> > fault_in_pages_readable and comments are wrong AFAIKS.
> 
> hmm. It says :
> 
> 		/*
> 		 * Bring in the user page that we will copy from _first_.
> 		 * Otherwise there's a nasty deadlock on copying from the
> 		 * same page as we're writing to, without it being marked
> 		 * up-to-date.
> 		 */
> 
> How can we improve it ? 

The page we're writing into isn't locked, so there's no deadlock afaict.

But then, I forget how xip works.  Carsten, is it actually being used for
anything?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/